Lily Wang
Lily Wang
Just ran into the R issue again with OpenEye š IMO a warning here would still be a good idea, and maybe reasonably easy to implement in the form or...
Sorry for the confusion, @aya9aladdin. This is quite an old issue and afaik we've moved away from using coverall but now use codecov: https://codecov.io/gh/MDAnalysis/mdanalysis/tree/develop/package/MDAnalysis If you click around on those...
So should DLPoly.ConfigReader and DLPoly.HistoryReader change to convert units when reading in forces? They don't seem to do that at present.
What do you mean by wrap -- do you mean raising a NoDataError if guessing can't happen, or catching it instead of an AttributeError? I skimmed the MDAKits failures and...
Sorry, it's late here, I'm not sure I'm fully understanding you -- if I rephrase, the issue is that the traceback is confusing because the Topology raises a NoDataError and...
Iām not following your reasoning here ā could you please elaborate? The errors for missing attributes should be NoDataErrors. This subclasses AttributeError, which is probably why the previous logic worked....
+1, sounds good to me, following the same logic as in #4751
+1 to copying over and deprecating -- sounds like the best course of action to me. IMO it would have been ideal to import the methods from the new location,...
Good point on trade-offs here -- IMO since it is actively used in our test suite (and would love to use it in the scenario of #4744, although it probably...
In general the actions versions could use an update.