pyfri

pyfri copied to clipboard

Add Automated Build/Tests

7

As part of the JOSS review (openjournals/joss-reviews#6138) I think this repository should have an automated build, preferably with some tests.

CameronDevine

Improve Documentation

4

As part of the JOSS review (openjournals/joss-reviews#6138) API documentation is required. I am finding some documentation in the Readme, and some in the Wiki, but I don't believe this is...

CameronDevine

FRI source via FetchContent

2

Suggestion for how to replace FRI target via [FetchContent](https://cmake.org/cmake/help/latest/module/FetchContent.html) - no submodule - cloned at cmake configure time - requires internet during build

mhubii

Support for asynchronous execution

2

Currently, the library only allows for synchronous execution, i.e. 1. KUKA controller sends a message to the LBR client 2. Depending on the session state the monitor, onStateChange, waitForCommand, or...

cmower

Add async support

2

Addresses #8. Todo - [x] test on real robot - [ ] account for any issues running on real robot - [x] expose PID initialization to python

cmower

I really like the new approach, nice work @mhubii! Here are some small modifications that I think would help keep the install method similar to before.

cmower

## 49 lines of code documented [Pipeline details](https://app.komment.ai/pipeline/5e40830f-82dd-45be-9f09-2d5ccc7383a8) The following files were processed: - pyFRI/tools/filters.py

komment-ai[bot]

## 1479 lines of code documented [Pipeline details](https://app.komment.ai/pipeline/433f5ddd-f29d-4166-b483-2bfc684f7004) The following files were processed: - pyfri/tools/filters.py - pyfri/tools/state_estimators.py - examples/LBRJointSineOverlay.py - examples/LBRTorqueSineOverlay.py - examples/LBRWrenchSineOverlay.py - examples/hand_guide.py - examples/joint_teleop.py - examples/task_teleop.py -...

komment-ai[bot]