Kyle Lemons

Hey @kevinburke ! Any chance we can get your thoughts on this? We rely on this package for an internal tool and a number of users have stumbled over this.

Thanks for the request. It's certainly probable that it should have been, but I am very reluctant to add something like this that will change the behavior for existing code,...

I haven't closed this because it's not 100% accurate, but there is a pretty-near-formal spec in the README and doc.go.

Unfortunately, changing an exported signature is a breaking change to the API. If you need transformations, I recommend [package cmp](https://godoc.org/github.com/google/go-cmp/cmp). I will tag this as a breaking change in case...

Hmm, yeah that is unfortunate. I think this would be too big of a behavior change for a minor version update, however. The reason for this is that Diff is...

I'm in favor of this. Getting pooling and other allocation-related performance bits correct has been a challenge for us with Thrift as well, so the advantages can go beyond protobuf....

I think that we should lean more heavily on io and os, rather than making top-level `WFile` types. In particular, I think we should basically just define some top-level functions...

I'd like to raise another use-case for detaching a context from cancellation and most values that I don't think has been raised yet, and that would be security context --...

I think the one argument version is the most consistent with sort.Search, but I think the two argument version gives the most flexibility by allowing for the use of non-closure...

Have you tested this version in production yet?