Kumar McMillan

Results 169 comments of Kumar McMillan
trafficstars

Ah, thanks for the details. I understand this better. Yes, I think the [build](https://developer.mozilla.org/en-US/Add-ons/WebExtensions/web-ext_command_reference#web-ext_build) command should produce `updateManifest.json` if the manifest includes `update_url`. I don't think `web-ext` should try to...

Note that the `sign` command calls `build` automatically

It may be easier to start this as a standalone command like `web-ext update-info` (or something)

> it needs the old updateManifest.json file to work This should be straight forward because we can decide on a standard file name like `web-ext-update-manifest.json` or something. It could be...

> you can use a single web-ext-update-manifest.json file for multiple addons Crap, so you can. That makes it a bit more complicated. I suppose the command will need to take...

Yes, so, we would need to specify the `update_link` URL on the command line in some way like: ``` web-ext ... --update-link="https://example.com/plugins/${xpiFileName}" ``` I thought of something else. The script...

if `applications.gecko.update_url` isn't in the manifest, no update manifest needs to be generated. I think it would be ok to expect the developer to add `update_url` manually when they want...

Great, thanks for getting it started! I can definitely give you an early review, just create a pull request and let me know when it's ready to look at. As...

The [sign()](https://github.com/mozilla/web-ext/blob/master/src/cmd/sign.js#L49) function from `cmd/sign.js` always returns a promise that resolves to a `signingResult` object. It is up to the caller to ignore it or not. Yes, it could be...

Hi @Hypnosphi . This issue is just about generating an update manifest. You should have no trouble running a private corporate extension on a release build using [web-ext sign](https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Getting_started_with_web-ext#Distributing_your_own_WebExtension). An...