Oliver Kopp

Results 1604 comments of Oliver Kopp

The diff should also be shown at "Save before closing": ![grafik](https://user-images.githubusercontent.com/1366654/199312591-3493a77a-7670-48c6-a1ff-adc041806133.png) I just opened JabRef, changed a preference - and JabRef told me that there is a diff ๐Ÿ™ˆ

> ~I'm curious what preferences change the bib file?~ I see, the citation key patterns are encoded as metadata in the library file. However, they are "only" stored there if...

> Can you look at the tests in test/jdk/tools/jlink, that is where we will need to add the test for this. I looked and started to create some Java files...

> I think there are still issues. As a quick test, set the maximum number of descriptors to generate per method to less than 70, so that you get Sub0,...

@AkshatJain9 you implemented "Each abbreviation should not contain \&" The check for "the starting letters should match somehow" is still missing. I don't know, how easy this is.

Could you say some words why these repositories are awesome? They make the impression that there were created only to gain a T-Shirt. ![grafik](https://user-images.githubusercontent.com/1366654/196432987-d495f810-b818-4ecf-a74c-26c8391c8ee3.png)

Same here. Maybe, you have similar settings than me? ![grafik](https://user-images.githubusercontent.com/1366654/200143079-3b2df649-bad3-48fd-991c-d047a98e009e.png) It used to work at 0.63.0

Nitpick ๐Ÿ˜‡: There should be an ADR (refs #2714) on using custom checkstyle rules versus [Google Java Style Guide](https://google.github.io/styleguide/javaguide.html). Besides the [two spaces rule](https://google.github.io/styleguide/javaguide.html#s4.2-block-indentation), I personally like it, because there...

On the CI, I get following error: ParseErrorRecoveryTest.labeledStatementSemicolonRecovery:62 ยป IllegalState ???... In IntelliJ, this test is green. Locally, with `./mvnw`, I also get this error. Not sure, how to proceed....

I added the string comparison. The other error still is there - maybe my grammar "fix" messed up some special case. Currently, I have no clue how to continue here....