Matej Knopp

> @knopp FYI, it looks like `FlutterVSyncWaiterTest.VSyncWorks` is flaky: > > ``` > [ RUN ] FlutterVSyncWaiterTest.VSyncWorks > [WARNING:flutter/shell/platform/darwin/common/framework/Source/FlutterBinaryMessengerRelay.mm(77)] Communicating on a dead channel. > [WARNING:flutter/shell/platform/darwin/common/framework/Source/FlutterBinaryMessengerRelay.mm(77)] Communicating on a dead...

@loic-sharma https://github.com/flutter/engine/pull/51405

> @cbracken is this still an issue after we landed the engine fix? It is fixed on macOS, but I believe while windows has the correct period the phase might...

I've added a [WIP PR](https://github.com/flutter/engine/pull/35894) to fix the threading issues. However there are still couple of pieces missing: - [ ] IOSurfaces for additional layers are constantly being created/destroyed in...

> Or just don't make the variable final? What is the value of shadowing versus a mutable variable? Shadowing is a completely different thing thing than rebindable declaration. Var will...

> > With shadowing every transformation can result in object of different type. > > The variable could be typed `Object`, so it is assignable by anything, but fair. I...

> Extensions are an alternative > > We can write: > > ```dart > final value = SomeThing() > .transform() > .otherTransform(); > ``` To a degree. This does not...

FWIW, rust clippy has a `clippy::shadow_unrelated` lint, that warns when shadowing an unrelated variable. So for example ```rust let data = get_data(); let data = base64::decode(data); ``` is fine while...

> Mutation is common and idiomatic. It's relatively rare for you to need multiple names for the same thing because most APIs let you just update the actual thing itself....

> Shadowing help if I can't think of better names. This is the only thing that it solves. Solving naming is not small thing. But it's also not the only...