Kit Bishop

Results 87 comments of Kit Bishop

Changed back to use SplitContainerDragger - Split editor part into separate PR https://github.com/godotengine/godot/pull/90439 For reference: `wished_middle_sep` is now `default_dragger_positions` and is now cached, `middle_sep` is `dragger_positions`. `_compute_middle_sep()` is split into...

> Would this be useful to implement [godotengine/godot-proposals#9676](https://github.com/godotengine/godot-proposals/issues/9676)? Yes, this (along with https://github.com/godotengine/godot/pull/90439) will make it easier to implement. `move_child` could be used instead of removing and adding children to...

I found a crash when duplicating SplitContainers with multiple children, I think it's related to how I dynamically add SplitContainerDragger as internal children. I add and remove them in the...

- Probably fixed by https://github.com/godotengine/godot/pull/75062

Rebased since https://github.com/godotengine/godot/pull/88003 is merged. I moved it into the Editor menu next to the layouts. Since its no longer top level I changed the name to 'Editor Docks', rather...

I don't think I can make them bold or colored, PopupMenu items don't support BBCode and they share the same theme. The open eye icon (`GuiVisibilityVisible`) makes it look like...

Here is how it looks with the Window icon with modulate: ![image](https://github.com/godotengine/godot/assets/10054226/a90a8ac3-cc31-4f47-862a-80b082b1765e)

Unexposed dock slot none and added close icon: ![image](https://github.com/godotengine/godot/assets/10054226/02cee25b-6cd0-4791-9b62-b5961686307d)

Updated to use opacity. ![Screenshot 2024-03-29 215143](https://github.com/godotengine/godot/assets/10054226/c0f5aea1-1380-4ac3-80cf-2e8ca49da968) Also, I realized that changing the theme wasn't updating it so I connected it to the theme_changed signal.

> You should use `NOTIFICATION_THEME_CHANGED` instead of signal (also remember that it's received when node enters tree, so avoid unnecessary update). EditorDockManager doesn't have get that notification, and putting it...