Kevin Hinterlong

Results 31 issues of Kevin Hinterlong
trafficstars

Do we have a way for users to control the sort order? _Originally posted by @jkusa in https://github.com/yavin-dev/framework/pull/1280#discussion_r593545359_

**Describe the bug** Filter values remove button should be the same across different filter operators **To Reproduce** Steps to reproduce the behavior: 1. Add equals filter with value 2. Add...

bug

By default the updatedOn date should be the last change, but it would be useful to keep it the same for migration purposes if manually specified https://github.com/yavin-dev/framework/blob/3a7ab53705ca16f30e9a66b00c50e94c3c99fbb4/packages/webservice/models/src/main/kotlin/com/yahoo/navi/ws/models/beans/Asset.kt#L51-L52

**Describe the bug** Column config button is transparent, it should use the theme background color https://github.com/yavin-dev/framework/blob/e800aeb29c73711d9812a9d50629ab94f5b1a73e/packages/reports/app/styles/navi-reports/components/report-view.scss#L114 **To Reproduce** Steps to reproduce the behavior: 1. Create a new report **Screenshots** ![New...

bug
Hacktoberfest
HackTogether

**Describe the bug** Navi Info Message does not use the theme to set the text/background color https://github.com/yavin-dev/framework/blob/3e2c63bb1d226327878aa4b0579964569d7eb998/packages/core/app/styles/navi-core/components/navi-info-message.less#L7-L8 **To Reproduce** Steps to reproduce the behavior: 1. Create a new report **Screenshots**...

bug
Hacktoberfest
HackTogether

Add `title="This (Column|Filter) is required"` message to the disabled remove button on required columns/filters to show why they are disabled https://github.com/yavin-dev/framework/blob/5f55675cd3b143605420dd29cdca8427456597ca/packages/reports/addon/components/filter-collection.hbs#L23 https://github.com/yavin-dev/framework/blob/1735bd35714b0d95d0365593b92cbe612bb79d1b/packages/reports/addon/components/navi-column-config/item.hbs#L16

Hacktoberfest
HackTogether

Do we need reorder on the non vc table? _Originally posted by @jkusa in https://github.com/yavin-dev/framework/pull/1280#discussion_r593488738_ This component isn't really needed so we should remove it

Hacktoberfest
HackTogether

> From conversation https://github.com/yahoo/navi/pull/724#discussion_r395671219 This is a legacy helper required from using `ember-composable-helpers` and relying on the fact that the `array` helper would return an ember array. After upgrading `ember-composable-helpers`...

Hacktoberfest
HackTogether

Can we make an issue to add an abort controller here _Originally posted by @jkusa in https://github.com/yavin-dev/framework/pull/1333#discussion_r601557331_

Hacktoberfest

_Originally posted by @kevinhinterlong in https://github.com/yahoo/navi/pull/706#issuecomment-596136888_ We found that adding `@tracked` to query params made directory almost unusable although it seemed to still work on chrome (firefox was pretty unusable)....