kbobrovs

Results 28 comments of kbobrovs
trafficstars

@AlexeySachkov, @bader - when we can expect this extension to be reviewed/merged? Some of ESIMD features depend on this.

> Even though I see how this can be useful, it might cause confusion if a function called printf is behaving differently from the normal printf. @rolandschulz, this confusion is...

> Unrelated failures What are the list of failing tests per each configuration?

@fineg74, could you please describe what the actual problem is - why unnamed ESIMD kernels lead to this problem?

We should try to limit ESIMD specifics penetration into general-purpose tools like post-link. My suggestion would be to find the wrapper function and add 'sycl_explicit_simd' metadata to it before doing...

... I would suggest to implement finding the wrapper and adding the metadata as a pass defined within the llvm/lib/SYCLLowerIR directory and invoked in sycl-post-link.cpp somewhere around (and similarly to)...

> All of this library code is part of the implementation, so I think all of the identifiers (aside from parts of the public API other than parameter names) should...

> > > All of this library code is part of the implementation, so I think all of the identifiers (aside from parts of the public API other than parameter...

I don't think C++ has enough tools to conveniently and reliably solve our problem here, so we need some compromise, I believe. For example - contrary to the LLVM coding...