Joe Previte

Results 464 comments of Joe Previte

> Maybe we can take the same path we do with the Helm stuff and delegate maintenance and testing of this to others. > If we are cool with that...

Sweet! @GNUxeava okay to get this in, I think we need to: - [ ] move this section to `install.md` - [ ] move `bash` script into it's own script...

Weird...it says there is an error since you don't have write access 🤔 I think this is fine for now. We can always edit later if needed.

> I noticed that the regex would match other strings than manifest.json such as manifest-json or something-manifest.json I'm guessing that wasn't intentional but let's double check with @code-asher.

Don't worry at all - sorry we missed this in the PR review. > Let me try and take a stab at this Sounds good! Thank you for offering to...

Hmm...I don't think there are workarounds. Is your company using Coder or is this some custom setup? @code-asher what are your thoughts?

I was able to reproduce this locally on macOS + Brave with `code-server --bind-addr 0.0.0.0:443 --cert` ![image](https://user-images.githubusercontent.com/3806031/151459496-ee880bd3-d259-4e1d-b59a-061c04555b24.png) ```javascript Error loading webview: Error: Could not register service workers: SecurityError: Failed to...

> accessing it via http. Images are rendered in webviews. Webviews use Service Workers. Browsers require HTTPS to enable Service Workers. Therefore, this isn't a bug in code-server since it's...

> But why does it work on localhost? Maybe browsers don't block Service Workers over http on localhost? I don't fully understand why/how it works, but yes, I think browsers...

@ky1emoon can you try with 4.2.0? Based on that error, it seems like you're not using HTTPS or your browser doesn't recognize the validity of your certificate perhaps. You could...