fix regex for manifest route
I noticed that the regex would match other strings than manifest.json such as manifest-json or something-manifest.json
I noticed that the regex would match other strings than manifest.json such as manifest-json or something-manifest.json
I'm guessing that wasn't intentional but let's double check with @code-asher.
Codecov Report
Merging #5219 (9f95fff) into main (04ff8c3) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## main #5219 +/- ##
=======================================
Coverage 72.42% 72.42%
=======================================
Files 30 30
Lines 1672 1672
Branches 366 366
=======================================
Hits 1211 1211
Misses 398 398
Partials 63 63
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/node/routes/vscode.ts | 83.33% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 04ff8c3...9f95fff. Read the comment docs.
I think this was because there used to be a webmanifest.json link in addition to manifest.json? But as far as I can tell everything is manifest.json now. Could we get rid of the regex entirely and just do /manifest.json?
@code-asher ready for review