Joe Previte
Joe Previte
Thinking out loud here...I believe the cookie is set here after you enter a valid password: https://github.com/coder/code-server/blob/ec3d9974b3494e6055c8e65e1fb0e4bc665429a7/src/node/routes/login.ts#L87 And this is where the logic for the cookie options are set: https://github.com/coder/code-server/blob/ec3d9974b3494e6055c8e65e1fb0e4bc665429a7/src/node/http.ts#L259-L286...
Workaround: select "Continue where you left off" in Chrome? See [here](https://stackoverflow.com/a/10772420/3015595)
Thanks for bringing this up @edvincent 🌮 My thinking: 1. Bring back the "hack" that was removed in https://github.com/coder/code-server/commit/4ae5e26ce7ed96a31c92211fc3026e1403725e3f, which moves it to an optionalDependency on our side 2. Try...
I think working in parallel - sending PR upstream and adding our hack back in the meantime - seems like the best approach 👍🏼 Let's go with that!
Double-checking, this isn't an issue in Codespaces?
I understand! Can you see if this bug exists in Codespaces?
@edvincent tagging you because I think you'd find this interesting. Also maybe you want to help with this? If not, no worries :) Seems like a one-liner.
> Can I sign-up to do this during the next week or so, or is this more urgent? that'd be awesome! absolutely no rush so whenever you have time :)...
> So, I don't think we should do that? I think the line between yarn and npm should be development of code-server vs install of code-server itself. I do agree...
> I don't think you can ;( Because vscode only comes with a yarn.lock file/expects yarn tasks... Actually, that being said, I believe the latest versions of npm respects the...