Jacob Hoffman-Andrews

Oops, I posted that before I saw @algesten had already provided a review! But I will still plan to find some time and take a look soon.

Looks like you've got a clippy error. Mind fixing that and I'll merge?

I think the racy-ness can be resolved like so: If the client timed out waiting for the `HTTP/1.1 100 Continue`, then when it tries to read headers again after sending...

> The pro of not merging it would be that then there wouldn't be a hurry to fix it before the next release, as it doesn't become a blocker. If...

hm, I think you are right.

I looked at https://docs.rs/cookie_store/latest/cookie_store/struct.CookieStore.html and I think _almost_ everything you need to make one is available on that type (plus serde and cookie::Cookie). The one unfortunate exception: https://docs.rs/cookie_store/latest/cookie_store/struct.CookieStore.html#method.from_cookies This is...

I'm curious @brandonros, what's the use case for using ureq in WebAssembly? If it's useful, we could probably do something where all the meaningful features are stubbed out to `fetch`,...

I'm in favor of accepting chunked responses with trailers, and maybe eventually providing access to them, though the interface would need some thought. I happen to have a branch where...

When we return the Stream to the pool, we can check that the `inner` `BufReader`'s buffer is empty.

An interesting problem! The first couple of solutions that occur to me: - During shutdown, if there are threads whose work you don't care about (because you want to cancel...