Jacob Hoffman-Andrews
Jacob Hoffman-Andrews
Right now the RA tries to handle errors during issueCertificate by calling out to `ra.failOrder`. However, in the most common case of failures during issueCertificate, the failure was caused by...
This only works if you assume there's only ever one RA. I think a more robust approach would be for the RA to update the database to set the status...
For rustls-ffi, I wrote up what I think is the correct solution: https://github.com/rustls/rustls-ffi/issues/244. Think of creation, giving away ownership, and freeing as a state machine. Most objects have a very...
@A248 The problem I describe solving in https://github.com/rustls/rustls-ffi/issues/244 is not that C code might pass a NULL pointer, it's that C code might pass a dangling pointer. That is, a...
> Why does the C code need to decide whether to free the pointer? Speaking in general, not about the specific case that prompted this discussion: All objects have a...
Thanks for posting about this. Can you tell us more about why you need to override the `httpPort` and `tlsPort` values? I would have thought that running on Docker would...
Good points @aaomidi. Other than that the code looks good to me, and we have an earlier approval from @aarongable. I'm going to land this, and we can explore plumbing...
At Let's Encrypt we deploy Unbound and unbound_exporter. We also semi-recently took over maintenance of the prometheus unbound_exporter tool: https://github.com/letsencrypt/unbound_exporter. Some reasons we would prefer to see Prometheus metrics exported...
Yep, we're planning to make a contribution. I've got working code at GitHub.com/jsha/corr. I just need to wire it up to config inputs. It turns out it needs both the...
Thanks so much for the PR! I'll review it soon.