J.P. RIVET comments

Results 6 comments of


                                            J.P. RIVET

inlineCritical CSS asynchronous loading method breaks with CSP

Thank's @tiberiuzuld :tada: I used your solution https://github.com/angular/angular-cli/issues/20864#issuecomment-844823912 for a Chrome extension created with **[email protected]**. I also needed the code generated by the `ng build` command to have no inline...

[Mime] [Email] Add encoders to text and html parts

Hi @kumulo, and thank you for your PR! 😄 It's an excellent idea, but we risk having limits as it is. I created a controller as in the example at...

[Mime] [Email] Add encoders to text and html parts

Stop all! It's all so unnecessary! :smile: After some investigation and a lot of help from @smnandre, it turns out that the base64 encoding option is already available in [`TextPart::chooseEncoding()`](https://github.com/symfony/symfony/blob/db1959827a9afa2d33752a459a5c07b667050fef/src/Symfony/Component/Mime/Part/TextPart.php#L213),...

[Mime] [Email] Add encoders to text and html parts

Rapid test with accentuated characters: ```php #[Route('/')] public function textHtml(MailerInterface $mailer): Response { $email = (new Email()) ->from('[email protected]') ->to('[email protected]') ->subject('Time for Symfony Mailer!') ->text('éàèéàèéàèéàèéàèéàè', null) ->html('éàèéàèéàèéàèéàèéàè', null); $mailer->send($email); return new...

[Mime] [Email] Add encoders to text and html parts

> For me, charset can depends of the part : https://www.rfc-editor.org/rfc/rfc9110#section-8.3.2 > > Or maybe I misunderstood something in the RFC. Perhaps this is a subject that should be explored...

[Mime] Fix address from string pattern regex

Hi ! Here are some of the cases I've just tested: | Case | Test | String | Expected Name | Expected Addr | |-|-|-|-|-| | 1 | ✅ |...