Joseph Lin
Joseph Lin
> > ``` > > } > > ``` > > Common parameters best practice - use common types There are definitions of common parameters in common-types/v3/types.json that you can...
> > ``` > > "description": "Identity to use for Key Vault Reference authentication.", > > ``` > > What format? Is it a resource id, or a guid, or...
@TimLovellSmith thank you for the review, I've addressed some of your comments with pushed changes and others added some more discussion. I'm unable to remove the `ARMChangesRequested` tag, can you...
I've pushed some more updates to address the latest PR comments, @weidongxu-microsoft do you mind updating the labels again for me so I can get another review on this? Thanks!
Hi @TimLovellSmith @raosuhas @weidongxu-microsoft I've addressed the comments and gotten the required checks to pass. Is there anything else pending or can we merge this PR?
@TimLovellSmith do you mind giving another review (since we're currently blocking on the requested changes)? @weidongxu-microsoft I will check in with Navy, thanks!
> > ``` > > "description": "Identity to use for Key Vault Reference authentication.", > > ``` > > To be clear, I'm just asking you to be specific in...
Thanks again @TimLovellSmith, @weidongxu-microsoft. Can you please give one more review and if all is good merge? Thanks!