Josh McKinney
Josh McKinney
Would RecieverSource be a reasonable name? This name would give a hint to the reader that it should be inserted into the event loop, that it will act generally like...
Perhaps the other side of a source might be a -Handle (or perhaps -Signal)? Thinking a little more about ReceiverSource, even that name might be a little (linguistically) confusing as...
Added an example which uses this: ```rust tracing_subscriber::registry() .with(tracing_subscriber::fmt::timing::TimingSubscriber::default()) .with(tracing_subscriber::FmtSubscriber::new().with_span_events(FmtSpan::FULL)) .init(); ```
Hey maintainers this is an alternative to #3038 - are either of these reasonable changes to make?
What about renaming this to SpanTimings instead of Timings? It's currently private, so this isn't breaking. Side note: My personal style would be to move this to its own small...
Hey maintainers, any thoughts about moving forward with this?
It's worth checking back on issues about what we discussed on this. I can't recall if we've previously done so. Would `Size` work for the param here?
Oh, I think you're saying that you wanted to do relative resize. I missed that. Yeah, you'd likely need a new type. But something that might also be a way...
Move is a keyword, which is why we settled on offset in the first place
Discussion of Offset naming for context took place in https://github.com/ratatui/ratatui/pull/533. It's worth expanding out some of the resolved comments to understand some of the naming concerns we discussed generally. I'm...