Josh McKinney comments

Results 1098 comments of


                                            Josh McKinney

Modularize Ratatui crate

What do we think about in ratatui-widgets putting all the widgets in proper modules rather than exporting at the root? I'm leaning towards making that a bit more obvious in...

Modularize Ratatui crate

I think I'd prefer to just acknowledge other things are blocked a bit for now, and take the time to get it right. There's nothing critical to release soon afaik...

`assert_eq!` should be consistently used in ratatui

Rationale: this makes it easy when reading failing test results to understand that the left hand side is always what actually happened while the right hand side is what we...

Introduce new way to compare visually output of layout tests

https://github.com/ratatui/ratatui/pull/1398#discussion_r1785596313 was the specific comment that spawned this issue.

fix(rect)!: Rect::area now returns u32 and Rect::new() no longer clamps area to u16::MAX

> What do you think of using `usize` instead of `u32` so it scales with the architecture’s pointer size? Because the height and width of a terminal is hardcoded to...

fix(rect)!: Rect::area now returns u32 and Rect::new() no longer clamps area to u16::MAX

I took a quick look to see if there were any obvious overflows and didn't see any that needed new tests.

fix(rect)!: Rect::area now returns u32 and Rect::new() no longer clamps area to u16::MAX

I took a quick look to see if there were any obvious overflows and didn't see any that needed new tests.

feat: add metrics (wip)

It might be worth experimenting with https://crates.io/crates/autometrics to simplify some of this.

feat(line)!: impl From<Cow<str>> for Line

> Does `foo.into()` work? e.g.: > > ```rust > let line = Line::from(foo.into()); > ``` No, that would have the same problem. both String and Cow are acceptable inferences for...