Josh Goebel

Results 1720 comments of Josh Goebel

How would we know that is a docstring vs just a normal string? We do currently support highlighting the `>>>` blocks within `"""` strings, as the `meta` scope (not as...

> Is there not a way to say that a string can contain a special highlighted pattern, and have rules for when that pattern ends? Sure, but the issue is...

So, you can't turn off the warning - not if it starts with `lang-`... `lang-` or `language-` are reserved meanings... anytime we see that we assume you REALLY want to...

> What confuse me is that, why the render test matched class first, instead of the not-matched class first to exclude some unwanted blocks. I'm not sure there is any...

I think the important part there might be "and the rouge gem". If they are using HLJS they are using a heavily modified version- I couldn't even recognize the markup,...

Probably an easy fix but I worry it's likely to shake up our auto-detect tests...

PR welcome... we're going to change the auto-detect stuff a lot in v12... and remove it from our test suite... it's just too flakey and not great in any case......

You can already specific the language manually, no? The needed fix to the grammar (which we should pursue) is likely a one line one just to remove this particular illegal.

I'm wondering if the `.` and `%` should be part of the match or not? (if not, probably punctuation?)