Jordan

Results 205 comments of Jordan

I would prefer this library to remain agnostic of any styling of the WebView, error display, or any other determinations of visual appearance. In my opinion, we should render an...

Hi, thanks for the report! This is because React 0.16 is not supported yet. `PureRenderMixin` has been moved to [`react-addons-pure-render-mixin`](https://www.npmjs.com/package/react-addons-pure-render-mixin) in React 0.16. I haven't gotten around to updating the...

For now, you'd have to use React 0.15.x, or modify this library to work with React 0.16. This library isn't compatible with React 0.16 yet, which is still alpha/pre-release status...

I also want to draw your attention to https://github.com/wallet-standard/wallet-standard It's still WIP, so while I'll continue to merge adapter PRs for the next few weeks, we are quickly moving in...

> Also regarding the openInfinityWallet function inside get url(), this is a necessary workaround for our unique implementation to allow for opening the DApp in the standalone Infinity Wallet app...

Please don't mark review comments as resolved when there have not been changes to the code in question.

Thanks for your PR. I won't be accepting it at this time because all requested changes have not been made and it's already taken up too much time in repeated...

The plan is that will be handled as part of https://github.com/solana-labs/solana/pull/26915 (see the "Message Formats" section) and encoded in the bytes rather than an extraneous parameter. The above linked spec...

I searched the existing wallet TS APIs `/signMessage\(.*?\):/` and didn't find any results indicating that wallets support this extra argument. If they do, it's not documented here. I'm closing this...

`?` may be prettier than `try`, but that doesn't make it more useful. I'd still argue that it's less explicit, less descriptive, less flexible, and more ambiguous. The point that...