Jordan

Results 205 comments of Jordan

This is probably the same issue as https://github.com/solana-labs/wallet-adapter/issues/519 and therefore likely fixed by https://github.com/solana-labs/wallet-adapter/pull/527. If it persists, please open a new issue with reproduction details.

`getWalletAdapters` is importing every single adapter and all their dependencies: https://github.com/solana-labs/wallet-adapter/blob/e89adf6cdc59ca33db0fcc3a27841a1f94a8b8ed/packages/wallets/wallets/src/adapters.ts#L25-L47 However that still sounds like a lot. Any chance you can come up with a chart to identify the...

Yeah, makes sense. Torus and Blocto look like the big offenders. The rest are basically coming in around the same, the bulk of which I imagine comes from the base...

Closing since tree shaking + enforced async loading for all adapters with external dependencies takes care of this locally. For browser extension wallets, work is underway on https://github.com/wallet-standard/wallet-standard

Hmm, this sounds like a bug. It's not specifically necessary to pass a default adapter -- it should be trying to use Torus (doesn't require installing a plugin), Phantom (most...

@safaiyeh thanks for the context. I may revisit your PR. I think we shouldn't favor any particular wallet or have their names hardcoded into this anyway.

> I think I probably don't understand the _original_ original problem that this PR sets out to solve. Same. I haven't had a problem using this project in WebStorm, does...

Closing in favor of https://github.com/solana-labs/wallet-adapter/pull/529

Closing here since polling isn't needed in https://github.com/wallet-standard/wallet-standard

@dnosk is this something you would like to work on implementing?