Johan Levin

Results 10 comments of Johan Levin

Thanks @daniel-white However, for my use-case I need to be able to clear the singletons with `container.clearInstances()`. I ended up using this instead: ``` import { DependencyContainer, FactoryFunction } from...

FWIW, I regularly see a very similar-looking crash when running pg 7.17.1 with an AWS Aurora Serverless database: ``` /home/jlevin/dev/backend/node_modules/pg/lib/client.js:329 self.activeQuery.handleCommandComplete(msg, con) ^ TypeError: Cannot read property 'handleCommandComplete' of null...

I have been using [ts-expect](https://github.com/TypeStrong/ts-expect) previously. ts-expect handles this case correctly, but it doesn't handle enums well. ts-essentials isExact works with enums but doesn't seem to handle `| undefined` the...

Thank you! I have verified that the PR fixes the code I had problems with originally, but you are right - it doesn't fix this case from my comment above:...

`| undefined` work fine now. But it looks like arrays are broken instead. This code works fine in `master` but fails in `fix/isExact-and-union-types`: ```ts declare const foo: number[]; isExact()(foo); ```

By the way, I was playing around with `isExact` and the `readonly` keyword and found another unexpected behavior. This is in master and perhaps unrelated to this bug, but I...

Thanks @Beraliv. Now both `| undefined` and arrays work. But enums appear to be broken instead. At least string enums with more than one value: ```ts enum SingleEnum { Foo...

Yes, you are right. I should have specified the enum type to avoid getting a too narrow type there.

@Beraliv, did you ever find a solution to this?

> [@johan13](https://github.com/johan13) I noticed that if I re-comment out `encoding.js:25` that all the tests still pass, including your `boolean_rle.parquet` test file from [#62](https://github.com/hyparam/hyparquet/pull/62). This makes wonder if that change to...