Johan von Forstner

Results 283 comments of Johan von Forstner
trafficstars

To create a new column in the database, you also need to increase the `DATABASE_VERSION` and create migration code such as ```java if (oldVersion < 7) { // Add column...

> On a side note, two new databases have to be created, so that means I have to create two new classes that extend the SQLiteOpenHelper right? Not necessarily -...

> Managed to add the databases for tags and the add and remove tags functions for StarDataSource. Not sure if creating a database instead of using the context in StarDataSource...

Hmm, I think the reason is that you are setting the tag [here](https://github.com/opacapp/opacclient/pull/510/files#diff-892b663b0818681cfa3d41c44a21ecbfR561) instead of in the click listener specified in `setPositiveButton` [here](https://github.com/opacapp/opacclient/pull/510/files#diff-892b663b0818681cfa3d41c44a21ecbfR555). When `addTag` is executed, `tagName` will still...

One suggestion regarding the UI: Maybe it would make more sense to just have one button on every item (e.g. with [this icon](https://material.io/icons/#ic_local_offer) ) that shows a dialog with the...

Very nice! > I tried to use the AutoCompleteTextView but it kind of resulted in the app not responding because of the database querying. I tried to load all the...

Ah - I think it's good in the current style - that's the default in Material Design.

No problem - hope the exams go well!