Joe Stump comments

Results 86 comments of


                                            Joe Stump

trafficstars

Added Request.sign() option to omit oauth_body_hash

@rickhanlonii this seems like something that's relevant to your work in #138 as well?

Added Request.sign() option to omit oauth_body_hash

@bensonk thanks for the PR! @jaitaiwan and @rickhanlonii are probably going to chime in on this as well. We need tests on this before we merge, but feel free to...

Added Request.sign() option to omit oauth_body_hash

@rickhanlonii I concur all around. @bensonk if you could add tests I'm :+1: after @jaitaiwan has reviewed.

cannot concatenate 'str' and 'NoneType' objects

@abrarazeem if you push a regression test into a PR, I'll look into a fix.

Properly identify the Authorization header's Realm part.

Good catch; you have a regression test (or an example request I can build one with?).

Twitter Three-legged OAuth Example has a flaw

It has not.

URLs are not normalised properly

@jaitaiwan this is a separate issue from #133, but related.

use the 'iter' attribute to determine if something is iterable vs a volatile error message

@k0s Thanks for the PR! Can you split out 2.4 fixes from the error fix? Also, needs tests.

Properly mock all tests requiring network access.

@jaitaiwan we should just be mocking the requests. So I think @wRAR's request is to mock these up.

Use imaplib2 instead of imaplib

@jaitaiwan I actually wrote this library because I was accessing IMAP and SMTP over OAuth in Gmail. We should look into this, particularly if it's drop-in.