python-oauth2
python-oauth2 copied to clipboard
Properly identify the Authorization header's Realm part.
This broke authentication whenever any of the oauth_ parameters contained the substring "realm" anywhere.
Good catch; you have a regression test (or an example request I can build one with?).
@joestump love his tests :+1: (so do I)
This is a great fix. It turns out that if (for example) the oauth_signature contains "realm" in the hash, it wouldn't be included in the params, which would be a nasty bug to track down.
@erikvanzijst I created the test for this on https://github.com/erikvanzijst/python-oauth2/pull/2. After you review and merge I think this is good to go.
Thanks @rickhanlonii you're a boss!
I pulled this PR into a new fork: https://github.com/TimSC/python-oauth10a