Jörn Röder

Results 64 comments of Jörn Röder

@JimmyMultani could you solve your issue?

i had a similar issue while i was writing the tests and fixed it quiet dirty: https://github.com/joernroeder/piwik-react-router/blob/master/test/client.tests.js#L13 i didn't find some time to look into this so please let me...

@mandarini thanks for looking into this. yes `s.parentNode.insertBefore(g,s)` seems to be the line which causes the problem. But i see some difficulties in changing is as it does exactly the...

yes. it also decides to append itself to the `head` or body. what did you tried? I think this is a valid use case and piwik-react-router shouldn't break your tests.

hey, thanks for your contribution and looking into this! i never felt comfortable with my hack and will review this pr within the next days. i was simply to busy...

hey @MattiSG, sorry for the late response. I actually thought about renaming this package before piwik changed it's name. The reason is that theoretically this package really doesn't require react...

Thanks for opening this pull request! I’ll look at it later - pretty busy today

hey, sorry i was simply to busy to check into this in the last weeks. will do a review of open PRs and issues this week. expect a new version...

hey @walokra, thanks for your contribution. i would love to merge your changes but would please you to add an additional test to the suite to cover the following line...

same error here. But I am getting after navigating via react-router to a page with react-scroll-section present.