piwik-react-router icon indicating copy to clipboard operation
piwik-react-router copied to clipboard

Published 20 hours ago • verified publisher icon joernroeder

Auto inject script

Open Viscosity4373 opened this issue 7 years ago • 3 comments

As discussed in #48, injection fails if the document does not contain a script tag. (For example in test suites with jsdom)

This simply checks for presence of a script tag and appends a new script tag if none is found.

Viscosity4373 avatar Jun 15 '18 09:06 Viscosity4373

Coverage Status

Coverage remained the same at 100.0% when pulling 4eaca033f3c984105c1ccd47dcfd75a9b05dbb74 on Klimakoenner:auto-inject-script into 9e618ad27c5c60e421d15d45607783c0c4513742 on joernroeder:master.

coveralls avatar Jun 15 '18 10:06 coveralls

hey, thanks for your contribution and looking into this! i never felt comfortable with my hack and will review this pr within the next days. i was simply to busy in the past few weeks.

joernroeder avatar Jul 30 '18 22:07 joernroeder

Hey! I would really appreciate if you could merge this fix. Can I help with this in any way? @joernroeder

cafca avatar Apr 15 '20 11:04 cafca