Joel Posti

Results 26 comments of Joel Posti

I first wrote these tests as integration tests. But I converted them to unit tests since it looks like the repo has zero integration tests. If you want these as...

Hello, absolutely. A repro is available in the form of tests in the pull request https://github.com/cetra3/mpart-async/pull/28. Check especially test `field_boundary_finding_should_not_cause_busy_exhausted_loop_2`.

It seems tests do not pass after making these changes. I will fix the issue.

Hei @Hilzu! Could you take a look at this pull request? I would like to have this issue fixed here in the upstream.

Thank you! Looks like the requirement has been reworded and moved to ARF 1.4 Annex 2 RPA_05. This issue can be closed.

Thank you! Looks like the requirement has been removed from ARF 1.4. This issue can be closed.

The proposed claim set does not seem to include a claim that would specify the namespace/credential type `eu.europa.ec.eudi.pid.1` in an issuer-agnostic way. Lack of such a claim makes it difficult...

Thank you very much @danielfett for your replies to my comments and for the changes you made! > > The proposed claim set does not seem to include a claim...

> > Either way custom mapping logic of vct values makes it difficult to determine whether the credential's type matches with eu.europa.ec.eudi.pid.1. That check is one of the basic checks...