Joel Maher

Results 23 comments of Joel Maher

@Archaeopteryx do you plan to get the tests green, and deploy this? I would prefer to prune old PRs from the repo

if you rebase this on upstream/master, you will fix the issue with circleci: builds.

please rebase on master branch to pick up changes to fix the issue with the broken builds job.

this looks like the same problem I am having.

this was originally a renovate PR to update query-string, but query-string became an ESM module and required more work, as it was not used much, I realized we could replace...

fixed the overall issue (thanks for calling it out). clicked around a lot, added graphs, etc. and all seemed ok. I do not have sheriff permissions to test that out....

thanks for finding the issue in the console. I have tested adding graphs, compare view, clicking on data points, highlighting alerts, etc. I do not have sheriff permissions to test...

I have added a small tweak and things are again looking great. I tried searching through the code for references to using /performance/* api calls as a way to test.

this is the way the production treeherder works today: https://treeherder.mozilla.org/perfherder/graphs?series=mozilla-central,2242563,1,4,mozilla-central,2242573,1,4,mozilla-central,2242583,1,4,mozilla-central,2242593,1,4&highlightAlerts=1&highlightCommonAlerts=0&highlightChangelogData=1&timerange=1209600

I think the missing & were a result of adding the graphs one by one with the patch. Using the URL you provided, I was able to reproduce. There is...