replace query-string with URLSearchParams

[jmaher]

[codecov-commenter]

Codecov Report

Base: 90.40% // Head: 90.40% // No change to project coverage :thumbsup:

Coverage data is based on head (7f0e41c) compared to base (a637a71). Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7609   +/-   ##
=======================================
  Coverage   90.40%   90.40%           
=======================================
  Files         296      296           
  Lines       15136    15136           
=======================================
  Hits        13684    13684           
  Misses       1452     1452           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[jmaher]

this was originally a renovate PR to update query-string, but query-string became an ESM module and required more work, as it was not used much, I realized we could replace it with built in URLSearchParams which reduces the need to manage as many npm packages going forward!

[beatrice-acasandrei]

@jmaher I believe graph links from Alerts View are affected by the changes. To reproduce:

1. Go on Alerts View (http://localhost:5000/perfherder/alerts?hideDwnToInv=1&page=1).
2. Find some alerts.
3. Click on the graph icon for any row, it should redirect to a graph, instead message 'Nothing here yet. Add test data to plot graphs.' is displayed.

[jmaher]

fixed the overall issue (thanks for calling it out). clicked around a lot, added graphs, etc. and all seemed ok. I do not have sheriff permissions to test that out. One thing here is I have a temporary hack in the .circleci/config.yml file, that will go away (ideally with https://github.com/mozilla/treeherder/pull/7614), I wanted the automation to be green to not confuse things.

please review or provide other feedback!

[esanuandra]

hey @jmaher there is a problem with highlighted revisions STR:

1. Go to compare view and select a comparison
2. Open graph link from a row
3. The alerts are put together with a comma in the first input So if we have two alerts to highlight they are not separated localhost treeherder

[esanuandra]

I think we found another bug STR:

1. Open Graphs View with some data
2. Open Job View for a data point
3. Details Panel does not load (there is an error in the console)

This happens only if you open jobs view from Graphs View.

[beatrice-acasandrei]

I am getting this on Graphs View.

[jmaher]

thanks for finding the issue in the console. I have tested adding graphs, compare view, clicking on data points, highlighting alerts, etc. I do not have sheriff permissions to test anythingelse.

[beatrice-acasandrei]

The Graphs View error is fixed but I get this error when accessing Jobs View from a datapoint in Graphs View.

[jmaher]

I have added a small tweak and things are again looking great. I tried searching through the code for references to using /performance/* api calls as a way to test.

[alexandru-io]

STR:

1. Open Graphs View and add two, three, four signatures
2. Copy the URL and paste it to a new tab
3. The URL will open the graph with first signature only.

[jmaher]

this is the way the production treeherder works today: https://treeherder.mozilla.org/perfherder/graphs?series=mozilla-central,2242563,1,4,mozilla-central,2242573,1,4,mozilla-central,2242583,1,4,mozilla-central,2242593,1,4&highlightAlerts=1&highlightCommonAlerts=0&highlightChangelogData=1&timerange=1209600

[alexandru-io]

this is the way the production treeherder works today: https://treeherder.mozilla.org/perfherder/graphs?series=mozilla-central,2242563,1,4,mozilla-central,2242573,1,4,mozilla-central,2242583,1,4,mozilla-central,2242593,1,4&highlightAlerts=1&highlightCommonAlerts=0&highlightChangelogData=1&timerange=1209600

interesting. i'm getting series joined by & you get joined by ,. Try: https://treeherder.mozilla.org/perfherder/graphs?series=mozilla-central,2242563,1,4&series=mozilla-central,2242573,1,4&series=mozilla-central,2242583,1,4&series=mozilla-central,2242593,1,4&highlightAlerts=1&highlightCommonAlerts=0&highlightChangelogData=1&timerange=1209600 How did you get your link?I',m just going to graphs and add all the signature by hand (Add test data) browsertime example

[jmaher]

I think the missing & were a result of adding the graphs one by one with the patch. Using the URL you provided, I was able to reproduce. There is a quick and simple fix for this which ensures series uses .getAll()

[jmaher]

this should be ready for testing again and review

[alexandru-io]

this should be ready for testing again and review

the issue is with modal. that doesn't generate correctly the URL. series=mozilla-central,2242563,1,4,mozilla-central,2242573,1,4,mozilla-central,2242583,1,4,mozilla-central,2242593,1,4 instead of series=mozilla-central,2242563,1,4 &series=mozilla-central,2242573,1,4&series=mozilla-central,2242583,1,4&series=mozilla-central,2242593,1,4

[beatrice-acasandrei]

@jmaher @alexandru-io On my side these fields are missing:

To reproduce go to Alerts View and click on the graph icon from a random alert.

[beatrice-acasandrei]

hey @jmaher there is a problem with highlighted revisions STR:

1. Go to compare view and select a comparison

2. Open graph link from a row

3. The alerts are put together with a comma in the first input
   So if we have two alerts to highlight they are not separated
   localhost
   ![image](https://user-images.githubusercontent.com/63001299/211014013-94137665-4eaf-42c3-91e1-5c8a39632939.png)
   treeherder
   ![image](https://user-images.githubusercontent.com/63001299/211014043-24e22785-7481-4c91-a0b4-e1486f595a99.png)

@jmaher This is still reproducing on my side.

[alexandru-io]

@jmaher if you want this to go faster, you can push it to prototype so we can test and share STRs and links directly from there, have the same testing environment.