Josh Lee

Results 53 comments of Josh Lee

Yes, your snippet is working. I had first tried `new stream.Readable({objectMode:true}).wrap(…)` to wrap the stream with the standard library version, and it emitted the first row then stopped.

Fair enough, thanks for trying to figure it out. I appreciate that swapping out the entire stream library would be a risky change, and a workaround exists for my use...

For TopGolf (https://github.com/osmlab/name-suggestion-index/issues/5678) we used `leisure=sports_centre`. That can communicate that it's more than your typical `leisure=miniature_golf` but that's still the primary feature.

![Screenshot_20201119-180951](https://user-images.githubusercontent.com/23022/99735455-a3679b00-2a92-11eb-8162-eca35346a323.png) Here's another issue with blue text on a dark background

There are also useless values in `name_de` and `name_en` for some reason. ![Screenshot_20220612-095135](https://user-images.githubusercontent.com/23022/173236614-b971f5e3-1d01-4aa7-beb9-34e724f126fa.png)

Attaching screenshot: ![image-1](https://user-images.githubusercontent.com/23022/147972177-1b588faa-bfed-4390-8cef-63839922dad5.png) There is a mismatch between the highlighted building (outdated) and the tiles (up to date).

https://github.com/ZeLonewolf/openstreetmap-americana/blob/078755abe95abd78a9527d2557bbe1605fa14481/style/layer/highway_shield.js#L52 This function ignores the `minzoom` argument.

The issue appears to be in the source data then, not the style: ![image](https://user-images.githubusercontent.com/23022/169655875-daac0a5c-6699-42dd-8a5d-aac3054e99d7.png) ```javascript > new Set( map.querySourceFeatures('openmaptiles',{sourceLayer:'transportation_name'}) .flatMap(x=>Object.entries(x.properties)) .filter(x=>x[0].startsWith('route_')) .map(x=>x[1])) Set(2) {'US:OH=7', 'US:US=22'} ```

~It's actually four separate lines in the tile. Does the frontend merge these?~ Never mind, I'm not looking at transportation_name here. ![Screenshot_20230914-185316~2](https://github.com/ZeLonewolf/openstreetmap-americana/assets/23022/a7c345c6-1279-442c-b582-cdf687dac5a1)

Probably also a tile change since these don't appear in the `route_1` properties: ![image](https://user-images.githubusercontent.com/23022/171917625-ec567700-ba6e-44df-acd4-7dbbf5fb4404.png)