Josh Lee
Josh Lee
If these are indeed deprecated, then it should log a warning. A formal deprecation policy (which doesn't exist yet?) could say, "deprecated items will produce a warning, and indicate that...
@ZeLonewolf Right, you would have to look at the generated style and then update the source by hand. I started in https://github.com/ZeLonewolf/openstreetmap-americana/pull/527, need to handle the exponentials next.
I don't know why the render test doesn't trip. Manual test:  The render test doesn't trip because it's a raster maxzoom of 1 and a...
Done, done. I note that https://github.com/maplibre/maplibre-gl-js/blob/main/CONTRIBUTING.md#changelog-conventions indicates to put changelog entries in the pull request.
Could factor out the logic to an exported function in either painter.ts or draw_debug.ts, then invoke it with various Maps and assert that it returns the desired SourceCache. The logic...
I think I can find some time this week.
Thanks for the code review.
Yes, thanks for the snippet. I tried `new Readable().wrap` and it was failing mysteriously. I'm not sure I understand why removing `readable-stream` would be a breaking change, but it nonetheless...
In fact, it apparently works (tests pass) all the way back to Node 0.10, which introduced the `stream.Readable` class. Before that I imagine we would still need the `readable-stream` library.
It only returned the first row: ```javascript > for await (const row of conn.query("select * from t").stream().pipe(new stream.PassThrough({objectMode: true}))) { console.log(row) } RowDataPacket { id: 1, data: '0' } RowDataPacket...