Jonathan Lebon

Results 607 comments of Jonathan Lebon
trafficstars

OK, pushed more code but still working on this. Notably, one thing I realized is that we really do want to run the postprocess scripts in the Containerfile _before_ rechunking...

OK, https://github.com/coreos/fedora-coreos-config/pull/3598 should unblock this now and fix the permission issues on import. That said, hacking on this locally... I think we should just cave in and basically add `ostree-commit`...

> The patch for osbuild from this PR resolved this. Awesome! It looks sane to me. Can you open a PR against osbuild? > Now the live iso won't boot...

OK updated this now! - rebased - reworked `cosa import` to inject `ostree-commit` - we also now keep the layers blob refs in tmp/repo because that allows more efficient imports...

Overall feeling pretty good about this. I think we can get this in almost as is; there's the osbuild patch which I don't think we should carry here before opening...

> (but: we need to add GC for these in cosa prune) OK added this now! Also added a check so that we error out early if we're trying to...

Comments addressed! Also re-added the osbuild patch since it's merged upstream.