Jonathan Lebon

Results 607 comments of Jonathan Lebon
trafficstars

Emphasizing the "WIP" part here. This is not complete, but hopefully is enough scaffolding to see how I've been thinking about this. The end goal should be that you can...

For the `meta.json` piece, the goal shouldn't be that we re-implement every piece of metadata in `meta.json`, but rather just the ones that are relevant for the new container flow...

Closing in favour of https://github.com/coreos/coreos-assembler/pull/4164.

> I'm getting error on cosa buildextend-qemu if this is the only build available and I'm looking at it. If there is a existing local build, I have to run...

> I found problem and fixed it now . For the record, the problem here was that `tmp/repo` was not initialized. This is normally handled by `prepare_build()`, which is called...

Make sure when testing this that you're testing with an FCOS built using https://github.com/coreos/fedora-coreos-config/blob/testing-devel/Containerfile and not what we currently push to https://quay.io/repository/fedora/fedora-coreos?tab=tags.

Nice! BTW, feel free to take over primary authorship on this. You've done a lot of non-trivial work on top at this point.

OK, actually we do something similar already in `import_ostree_commit` that would make sense to mesh with. Whipped this up: ```diff diff --git a/src/cosalib/cmdlib.py b/src/cosalib/cmdlib.py index 00c2ce80c..c38129f67 100644 --- a/src/cosalib/cmdlib.py +++...

> We need the commands to get commit from a repo as a separate to use in cmd-osbuild. Currently it reads ostree-commit from meta.json. I have changed it to read...

OK, pushed an update here to rebase, fix CI and do some minor cleanups. Still testing/reviewing this locally. Also flipped author and co-authored-by. :) > Checked `cosa kola run` and...