Jesse Glick

Results 604 comments of Jesse Glick
trafficstars

> I'd recommend that any additions are marked as "experimental" Not sure if this is good enough: https://github.com/jenkinsci/docker-plugin/blob/cde48970a0ccb2260afa290d020de79dda66ae4d/src/main/java/io/jenkins/docker/pipeline/DockerNodeStep.java#L105

@bverkron I _think_ this PR would address your use case, excepting the build from `Dockerfile` followed by use of that image in later stages of the same build which may...

Before this PR: * Scripted or Declarative with a label matching an admin-configured Docker cloud; server endpoint in global settings * Scripted `docker.image.inside` ~ `withDockerContainer`, or Declarative `agent docker` or...

So ```groovy agent { docker { image 'jenkins/jnlp-slave' label 'testslave' } } ``` is basically sugar for ```groovy node('testslave') { // e.g., a VM with a local Docker server withDockerContainer('jenkins/jnlp-slave')...

> This does not allow for things like `image 'jenkins/jnlp-slave'` to be included in the declarative script And that is where `dockerNode` comes in: it works basically like the first...

> shortcoming of the existing docker plugin Unclear if this comment refers to _this_ plugin or `docker-workflow-plugin`, specifically the `withDockerContainer` step.

> the code for PVs concurrent See #4242.

> I need it in incrementals, so I can make an integration test in workflow-cps, so i converted it to to PR (removed draft) Incrementals are published from draft PRs.

https://github.com/jenkinsci/git-plugin/pull/898#discussion_r448561267 should be investigated. Also that PR touches `GitTelescope` (whatever that is). Need to examine prior art.

@MartinKosicky by the way when you force-push inside a PR, it breaks the ability of GitHub to display incremental diffs to reviewers. Generally I advise simply pushing commits to the...