Jesse Glick

Ah I was just missing a `save` call in the new path.

(merge conflict)

amending #269 FTR

Probably fine so far as it goes but I suspect what you really wanted was ```diff diff --git src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubAppCredentials.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubAppCredentials.java index c4f45cf..f062de5 100644 --- src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubAppCredentials.java +++ src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubAppCredentials.java @@ -323,6 +323,11...

@schiasileon do you have some one-character passwords? …is it `x`?

> a custom implementation Of what? > multiline secrets from vault where we have some troubles with single character lines or empty lines being treated as separate secrets Secret masking...

https://github.com/jenkinsci/jenkins/runs/47909286867 already passed, so why fe240d49749676efccdef2a74f4572469f5ed48f?

> all PRs needed syncing with master and passing CI before merging All PRs need to pass CI before merging. This one already had, as of febf94414d243122c906b98a42ff99f98162c664. I am not...

This is not just about tests—if you _need_ to set these properties in order to get tests to run promptly, it is a sign that _production_ code is lacking an...

`CommandInterpreter` and `AbstractBuild` are not involved in a Pipeline build, FYI.