Jesse Glick

Results 606 comments of Jesse Glick
trafficstars

Did you mean to show a thread dump excerpt here?

> loading of plugins/extensions […] should be consistent with the classpath calculation In general, if you need to delve into this kind of detail, you should switch to `RealJenkinsRule`.

> I cannot recall why it was in the current order to begin with. One reason I remember now: in the normal case that the snapshot version changes (in the...

> a bit of unnecessary extra work Yes of course, but small I think (one line of XML which you would be prompted to add to the POM); and the...

Seems easy enough to just update the parent (or run with `-Dhpi-plugin.version=…`), but TBD.

Everything related to `ScriptApproval` should be considered basically deprecated (do not use this system), and adjusting the UX is certainly dangerous. If @daniel-beck or @Wadeck wants to review this and...

> outside of pipeline and where sandboxing isn't really possible. Email-ext templates for example Getting off topic, but FWIW many cases would be better handled by replacing that plugin with...

> this code does not "trust PR revisions when approved" which is what the Jira title is. That is confusing and should be changed Right, the original proposal in the...

> it is unclear if this was the commit at the time of the submission of the review or what you had open in the web browser. In my experience...

> not so sure about not trusting causes based on a denylist rather than an include list Putting into draft while I investigate options.