John Firebaugh comments

Results 208 comments of


                                            John Firebaugh

Path `setStyle` ignores `className`

From #2936: I don't think setStyle should actually change the className. The class is not really a style property, and the logic necessary to handle `leaflet-` classes seems like a...

Import from parent directory causes: Cannot find module

I can't get it to work even with the `rootDirs` workaround. Here's a simple test case: https://github.com/jfirebaugh/rules_nodejs_test/tree/simplified

Add a way to undo a specific change just before saving?

Previously: #537.

Dropped 21/21 stack traces because of errors / Failed to copy memory address 0

Thanks @acj. Bundler 2.2.32 on macOS 12.5.1.

Make query methods return raster features/sources

#5916 notes that raster layers with a canvas source should be included with this feature.

Offline Tile Count API

Note that the tile count depends on the `minzoom` and `maxzoom` specified in the source's TileJSON, so calculating it depends on having downloaded at least that resource.

building with race detection (`@io_bazel_rules_go//go/config:race`) is very slow especially if using Go binaries to generate code

We encountered this issue in the Figma monorepo. > The fact that the stdlib needs to be recompiled with race detection is a problem For us, this is the primary...

Add `go_cross` rule for cross-compilation.

Just curious, what's the advantage of `go_cross_binary` versus using the `--platforms` flag? The latter seems like the [officially recommended](https://bazel.build/concepts/platforms#goal) way to do cross compiling with Bazel. (Although `--platforms` doesn't seem...

Add `go_cross` rule for cross-compilation.

Thank you for the explanation, that makes sense. I encountered two issues with rules_go's support of the `--platforms` flag: * I was trying to use a self-defined "linux_amd64" platform rather...