John Firebaugh

Results 208 comments of John Firebaugh

This is also a problem for pnpm. I submitted a workaround in #2121.

Anything we can help with to get this PR merged? We've been running a patched version of Gazelle at Figma with this change to avoid it getting OOM killed. Seems...

The root issue here is https://github.com/browserify/commonjs-assert/issues/38.

Definitely chai makes sense as a peer dependency. Not sure jQuery does though -- it should work with pretty much any jQuery version, so there's not really anything for peer...

Yeah, it's true that the node API is currently a second class citizen. The standard convention for chai plugins is to export a function which can be passed to `chai.use(...)`,...

It would be extra cool if the "Rename" refactoring automatically generated the appropriate `moved` block!

This seems to be fixed. `vsce package` currently completes without error.

Try removing the trailing slash from `"bazel.buildifierExecutable": "/usr/local/bin/buildifier/",`.

This seems to be fixed. `vsce package` currently completes without error.