Jeremy Evans
Jeremy Evans
You've turned on verbose warnings manually (verbose warnings are disabled in the default rake task). I think ideally it would be good to get the tests to run in verbose-warning...
I've fixed the verbose warning issues in https://github.com/jeremyevans/tilt/commit/4f80d2cb48ef830da44b7ac04dbf9625235ab852 (new upstream repository)
@judofyr Any chance you could merge this? The gem homepage isn't important, but updating the README would be helpful.
I think it's a good idea to enable yjit by default.
If you want the cache to be thread-safe (especially important on JRuby/TruffleRuby), then something like `RodaCache` with an added `fetch` method (made thread-safe) seems like the best approach.
I would like this behavior in 3.1. This was the original Rack 3.0.0 behavior. We compromised our integrity to change the behavior to be the same as 2.2 in response...
> @jeremyevans sorry to impose, but do you mind giving a brief summary of the advantages of this change again? Compliance with the URL spec, section 5.1.3.3. You agreed that...
> If that's the case we should probably punt this to a future release of Rack. OK with me.
I'm OK with merging this if the conflicts and test issues are fixed.
We should close this, none of the requested backport commits are security related.