Jeff Epler

Results 132 comments of Jeff Epler

This fails on the community bundle due to invalid syntax that is accepted by circuitpython but not python3. Before now, library code was not actually required to be valid python3....

## Writing zero-overhead type checking for CircuitPython We love type hints! They improve documentation as well as developer experience in Python-aware IDEs. Unfortunately, these additions can sometimes increase the size...

No, the code takes care to preserve line numbers.

the test case (note the lines are cut off): ``` 1 from __future__ import annotation | 2 | 3 try: | 4 from typing import TYPE_CHECK | 5 except ImportError:...

It's lengthy, but here are the diffs for the adafruit bundle: https://gist.githubusercontent.com/jepler/8e9e477e84d65a81da36aa0db2eb4864/raw/db8354aea74f313e6e97b7543a06986cc59980ac/munge_changes.patch It's nigh impossible to review that much repetitive junk but I can say I didn't spot anything problematic...

```$ circuitpython-munge --help Usage: circuitpython-munge [OPTIONS] INPUT [OUTPUT] Options: --diff / --no-diff --munged-version TEXT --help Show this message and exit. ```

the core will need to learn how to "munge" files when it builds in frozen modules. the circuitpython-munge script would be helpful for that.

I did my best to spot check the results, and didn't find any erroneous transformations. However, it's entirely possible there are some and I just didn't see them. It's possible...

I'd love to see this happen someday, but it's anything I'm going to be promoting right now. It's good to know there are some things we can potentially do to...