Jeff Epler

Results 136 comments of Jeff Epler

I went ahead and ran isort across the bundle and found at least one problem. Note: finding one problem, or a small number of problems, shouldn't stop us from doing...

about 50 "+" lines in the resulting diff across the bundle also contain "pylint" so that probably is approximately the scope of what will need human attention. This is in...

*most* libs have a change introduced by isort. That wasn't what I concentrated on, because running pre-commit alone would fix the problem. The following have a change affecting a line...

I think the cookiecutter change can be merged without immediate additional work, and it'd cover new libraries. It's just that when updating pre-commit later via adabot patch it'll require individual...

oh, wait, when running isort I think we want the "black profile" ``` - repo: https://github.com/pycqa/isort rev: 5.12.0 hooks: - id: isort name: isort (python) args: ['--profile', 'black'] ``` or...

and pylint wrong-input-order does seem to need to be disabled globally

No, I don't have that context from last year anymore, sorry.

To better show what I mean, suppose you change the pylint to a "teapot check", which * prints "I am a teapot" * prints the files that pre-commit believed the...

Since the last round of pre-commit changes, we've discovered a few things about how better to use pylint from pre-commit. However, as the impact of this is actually rather modest...

Did this get implemented or is there something left to do?