Juliusz Chroboczek

Point 2 has been adressed -- we now do things properly, in *n log(n)* time. Point 1 remains.

This is not unlikely — I'm not happy with the code that keeps track of interface status, it feels fragile to me. Rewriting if_up in interface.c might be a good...

Note further that this is not going to be changed in the 1.8 branch (which only takes critical bug fixes), so if you intend to work on this issue, please...

Your patch series looks good. The only thing I don't understand is what happens when the (external) IP address changes. What's more, I'm not convinced that BEP-42 is a good...

Does this work with BSD Make? Or have you introduced a hard dependency on GNU Make?

Please submit separate patches for separate features: - making it easy to use system libraries; - making the substitution automatic. Please be aware that my Make-fu is very primitive, so...

Sorry, the logging infrastructure won't go in.

Agreed, that's a good idea. And it would not be too difficult to use the priority even if rules are added at runtime.

Can you provide tcpdump traces that show that this patch actually does something?

> If adding TCP Fast Open is welcome in polipo, I can try provide the > complete patch set along with any supporting logs, pcaps. Please. Just a well-chosen pcap...