Jay OConnor comments

Results 10 comments of


                                            Jay OConnor

use rubocop for linting. ran safe autocorrect

@camertron

Rather than auto update certs, or a cron job. consider Rails.cache.fetch?

I'm happy to take this on. My idea is to make a new configuration block that would take any `ActiveSupport::Cache` object and look like ```ruby FirebaseIdToken.configure do |config| config.cache_store =...

Rather than auto update certs, or a cron job. consider Rails.cache.fetch?

WIP: https://github.com/fschuindt/firebase_id_token/pull/43

use rubocop for linting. ran safe autocorrect

out of date. closing

allow cache to be an ActiveSupport::Cache object

This should be a minor version bump the way it is. There's a major version bump that changes the initialization interface that I will recommend. Old way ```ruby FirebaseIdToken.configure do...

allow cache to be an ActiveSupport::Cache object

it can be. I think it is a bit confusing, because the redis cache option allows for the same base functionality. I'll put that together as a friendlier way to...

allow cache to be an ActiveSupport::Cache object

Thanks for the feedback. The old config will work and operate like it did before. The new configuration will use the `fetch` block, which eliminates the need to download certificates...

allow cache to be an ActiveSupport::Cache object

closing temporarily for a bug I found

allow cache to be an ActiveSupport::Cache object

ready to be reviewed again. sorry for the back and forth

allow cache to be an ActiveSupport::Cache object

@lsglucas thanks for the kind words