John Derr

So I did a little debugging and checked ember 3.6 with ember-decorators-polyfill: * typeof "function" * isDescriptor is true * constructor `dec` - constructor.name "DecoratorDescriptor" * https://github.com/pzuraq/ember-decorators-polyfill/blob/v1.0.3/vendor/ember-decorators-polyfill/index.js#L209 ember 3.10.0-beta.2 *...

I started digging into the tests that are failing and it looks like the dependent keys for the model in the`options` object are not being recognized when the CPs are...

I was able to work around this issue by creating a `dependentKeys` object on the validation. This got all the cp related tests passing in the PR @Alonski submitted. ```...

For 3.10 I had to update `addon/-private/options.js` to make the constructor always extend the object. ``` export default class Options { constructor({ model, attribute, options = {} }) { const...

@ alejandrodevs I'll start by running the tests with ember-try and see what comes up.

> > For 3.10 I had to update addon/-private/options.js to make the constructor always extend the object. > > This is very expensive to do and I would prefer to...

Any additional thoughts on how to update this addon? Decorators have shipped in 3.10 which will cause a couple of issues if you are using a computed property in a...

> When do we need to do this `model. will need to be explicitly added to dependentKeys`? See this example: https://github.com/offirgolan/ember-cp-validations/issues/635#issuecomment-485315979 The disabled attribute of `lastName` is set using a...

Hello! I made an attempt at this and ran into issues about whether this is possible. I made the changes as outlined here: http://ember-cli-page-object.js.org/docs/v1.13.x/native-events This broke 12 tests total, all...

@begedin This is good timing, I am at EmberConf so it is a good time for me to revisit it. I'll start with a PR.