jchristgit

Results 131 comments of jchristgit
trafficstars

@wookie184 thanks for the review and sorry for the long delay. I've updated the response format, the "sluggified" / "kebabified" version of the names can now be found in the...

Looks like I managed to mess up during rebasing. It should all be fine now, and the code should be a lot simpler thanks to Rohan's changes. Please also see...

Migrations are merged, `display_name` was added, please re-review.

@jb3 > I may misunderstand Django migrations and this may be a non-issue, but do we need to update the dependencies of the 0093_user_alts migration to instead depend on 0095_user_display_name...

Hmm, I can't reproduce this anymore either, maybe because of #1161 or something similar? I agree with you on the other points. I will update this issue for those

Actually skip that. I've found a reliable way to reproduce it: - In Firefox, open devtools, then go to the network tab - Select "Regular 2G" - Force refresh There...

Wow, I didn't know that, but it does indeed seem to be a Firefox bug! That's really annoying. And the fix is kind of strange... I wonder if it's worth...

Hmmm. I think it would make more sense to move the `REDIS_USE_FAKEREDIS` hint into the linked & missing section..?

> IMO, having a note on fakeredis there (like right now, but amended) lets people quickly set up the [development environment](https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/sir-lancebot/#development-environment) with the required env vars (such as redis ones)...

The site feature has been implemented, so this issue can now be worked on.