Joachim

Results 89 comments of Joachim

> > Looks good to me. > > We still need someone to check the API. > > I think it will need to add code snippet with definition API...

One more thing: we probably should only delete OOMing pods if we plan to increase their memory request. We have information about current request and about recommendation target in updater...

Hi, I'm back. It looks like we're stuck a bit on whether we should have just API change or API change and flag. I'd like to ask to help. @RuriRyan...

Thanks. I think it would be good to have an enhancement proposal for this. In the enhancement proposal I'd like to see: - Short explanation why we want this -...

I was writing in hurry. Let me try once more. Thanks for sharing this. I'll take a look when I have some time (I expect next week). Reading the PR...

LGMT I think I need someone who knows more about API to take a look too

I meant to leave those comments on the PR with KEP

/hold While I'm working on VPA 0.12.0 I don't want to make any changes to VPA that are not related to the release (I think code is good to go...