autoscaler
autoscaler copied to clipboard
kubernetes
[VPA] KEP-4902: Delete OOM Pods
Which component this PR applies to?
vertical-pod-autoscaler
What type of PR is this?
/kind documentation
What this PR does / why we need it:
KEP for #4730 and #4898
One more thing: we probably should only delete OOMing pods if we plan to increase their memory request.
We have information about current request and about recommendation target in updater so it's doable. I'm not sure how much work it will be. But I think we should do it (or at least note to do it later).
One more thing: we probably should only delete OOMing pods if we plan to increase their memory request.
We have information about current request and about recommendation target in updater so it's doable. I'm not sure how much work it will be. But I think we should do it (or at least note to do it later).
line https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/pkg/updater/logic/updater.go#L260 returns a list of pods and could potenially be changed to return more information. But this is only a surface level view and more or less the first thing I found.
I'll add a section describing this and try out a couple implementations to see how easy it is, if it gets too complicated i'll leave a note.
Hi, I'm back. It looks like we're stuck a bit on whether we should have just API change or API change and flag. I'd like to ask to help.
@RuriRyan @voelzmo Can you make it to the SIG meeting today? If you can maybe we can resolve it over there? Sorry about asking about it at the last moment
This PR may require API review.
If so, when the changes are ready, complete the pre-review checklist and request an API review.
Status of requested reviews is tracked in the API Review project.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jbartosik, mwielgus, RuriRyan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~vertical-pod-autoscaler/OWNERS~~ [jbartosik,mwielgus]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
