jay vyas

Results 206 comments of jay vyas
trafficstars

(although obviously you cannot unit test block locality in the JVM) - but a unit test which at least tests that some of the logic of the code youve added...

Hi, when you run "mvn package", will get a jar in target/. It won't match the exact version number in this readme of course. Maybe we should update the instructions...

preapproved +1 , pending addition of a Log.info("Setting buffer size to ...........") statement. otherwise this is really hard to debug at scale in case any issues.

good point steve :) Retracting my +1 until you merge my unit test :) :) https://github.com/gluster/glusterfs-hadoop/pull/65 (or just copy the code - i dont care about the pull request, just...

nice one brad +1. real quick before you merge: can you confirm that the unit test passes now ? I've confirmed that it fails on the old shim which uses...

hmmmmmmm okay will patch it up . you want me to commit to your childsb/branch ?

hola. The test is failing for all the right reasons: The default buffering is still 4096 bytes. :)... You need to update your "if ..." statement to override the default...

Well, nevermind. I guess i will patch the test so that it confirms that the io.file.buffer.size parameter is honored and let you folks work out the details of wether or...

``` //this test will pass, edit (bufferSize) to be larger, once we decide what gluster should allow as a minium. @Test public void testBufferSpill() throws Exception { Path out =...

thanks brad : when we merge this, are we going to bump version to 3.0.0.?