Results 773 comments of James Addison

> > because the inventory entries' identifiers are the same when compared case-insentively. > > I'm wondering what could have been the motivation for case-insensitivity in intersphinx? Maybe because intersphinx...

This is a clever way to implement the feature without having to change the format of the search index (`searchindex.js`) file! My main concern is that it relies on the...

> An alternative implementation I have in mind would involve storing the location of each term in the documents it was found in as part of `searchindex.js` -- and then...

Despite my initial flip-out about an implementation that isn't index-driven, I would note that this is the [most-requested search-related feature](https://github.com/sphinx-doc/sphinx/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc+label%3A%22html+search%22) in the bugtracker. That's bringing me more towards acceptance of...

If a user runs a query for `golang "code example"` and no pages contain the phrase 'code example', but pages do contain 'golang', do we have a preferred outcome? (zero...

Hmm. Would searching for `"that with"` on a large (English-language example, but generalizable to others) documentation set potentially launch many, many HTTP GET requests with this?

> Hmm. Would searching for `"that with"` on a large (English-language example, but generalizable to others) documentation set potentially launch many, many HTTP GET requests with this? Hm. Fortunately not,...

> For me, quotes should be what I want to search, even if it contains the rest. Quotes mean "I want that _exact_ string, I don't want anything else". So...

> I think my largest concern about these changes remains the effiency/time-cost of the client reading through the entire contents of documents for matches. I could draft an ngram-based solution?...

@wenzhixin I haven't yet heard from any affected bugreporters, but I believe that this pull request solves the problem described in #7171 when the `filter-control` extension is used in combination...